test: e2e/staking to system tests #21882
Conversation
del: e2e staking tests
WalkthroughWalkthroughThe changes involve the deletion of end-to-end test files related to the staking module in a Cosmos SDK application. Specifically, the files Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (3)
tests/systemtests/staking_test.go (3)
36-36: LGTM: Increased stake amount for better test coverageThe increase in staking amount from 10000stake to 1000000stake significantly enhances the test coverage. This aligns well with the PR objective of improving the testing framework and may help detect issues that could arise with larger stakes.
Consider defining the stake amount as a constant at the top of the file for easier maintenance and readability. For example:
const testStakeAmount = "1000000stake"Then use this constant in the test:
rsp = cli.RunAndWait("tx", "staking", "delegate", valAddr, testStakeAmount, "--from="+account1Addr, "--fees=1stake")
42-47: LGTM: Added validator update checkThe new section to check if the validator has been updated directly addresses the PR objective. It effectively queries the block results and verifies the validator's public key, enhancing the test coverage.
Consider adding a more descriptive error message to the
assert.NotEmptycall to provide clearer context if the test fails:assert.NotEmpty(t, validatorUpdates, "Expected non-empty validator updates after delegation")
Line range hint
1-63: Overall assessment: Significant improvements to test coverage and alignment with PR objectivesThe changes made to this test file substantially enhance the coverage of staking and unstaking operations:
- Increased stake amounts provide a more robust test scenario.
- The new validator update check directly addresses the PR's main objective.
- All related assertions have been consistently updated to reflect the new stake amounts.
These modifications align well with the PR objectives and strengthen the testing framework. The test now covers a wider range of scenarios and includes crucial checks for validator updates.
Consider adding edge cases to further improve the test coverage:
- Test with the maximum allowed stake amount.
- Test with the minimum allowed stake amount.
- Test multiple delegations and undelegations in a single test to ensure cumulative effects are correctly handled.
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (4)
- tests/e2e/staking/cli_test.go (0 hunks)
- tests/e2e/staking/suite.go (0 hunks)
- tests/systemtests/getting_started.md (1 hunks)
- tests/systemtests/staking_test.go (2 hunks)
Files not reviewed due to no reviewable changes (2)
- tests/e2e/staking/cli_test.go
- tests/e2e/staking/suite.go
Files skipped from review due to trivial changes (1)
- tests/systemtests/getting_started.md
Additional context used
Path-based instructions (1)
tests/systemtests/staking_test.go (3)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
Additional comments not posted (5)
tests/systemtests/staking_test.go (5)
15-15: LGTM: Clear and relevant comment addedThe added comment "// check validator has been updated" aligns well with the PR objective of including checks for validator updates. It enhances the readability of the test by clearly stating the purpose of the upcoming code.
33-33: LGTM: Validator public key retrieval addedThe introduction of the
valPkvariable to store the validator's public key is a necessary addition for the new validator update check. The use of thegjsonlibrary for parsing is consistent with the existing code style.
40-41: LGTM: Updated balance assertionThe assertion for the account balance after staking has been correctly updated to reflect the increased stake amount. This change is consistent with the modification in the staking amount and ensures the test remains accurate.
50-50: LGTM: Updated delegation amount assertionThe assertion for the delegation amount has been correctly updated to "1000000", reflecting the increased stake amount. This change maintains consistency with the earlier modification in the staking amount and ensures the test remains accurate.
58-58: LGTM: Updated remaining delegation assertionThe assertion for the remaining delegation amount after unbonding has been correctly updated to "995000". This accurately reflects the increased initial stake amount (1000000) minus the unbonded amount (5000). The change maintains consistency with the earlier modifications in the staking amount and ensures the test remains accurate.
julienrbrt
added
the
backport/v0.52.x
(cherry picked from commit c971f75)
Co-authored-by: Julián Toledano <[email protected]>
Description
Updates current staking system test to also checks validator updates
Closes:
#21874
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
Bug Fixes
Tests
TestStakeUnstakefunction to improve validation of staking and unstaking operations, including updated token amounts and validator public key checks.Chores